From: Phil Hagelberg <phil@hagelb.org> To: "technomancy\/slamhound" <reply+i-22033298-3767ef60e6b7b9cdb87818df96861936bd9c37c3-141@reply.github.com> Subject: Re: [slamhound] New ns form parser for more reliable disambiguation (#53) References: <technomancy/slamhound/pull/53@github.com> User-agent: mu4e 0.9.9; emacs 24.3.50.1 In-reply-to: <technomancy/slamhound/pull/53@github.com> Date: Sat, 09 Nov 2013 13:47:32 -0800 Message-ID: <87eh6p9rij.fsf@enigma.home.hagelb.org> MIME-Version: 1.0 Content-Type: text/plain Wow, this looks like a really solid improvement. It's nice when the codebase can remain simpler, but I think you're right that in this case the original implementation was very naieve; this is a lot more comprehensive and thorough. It looks like you have :reload/:reload-all in slam.hound.asplode/empty-ns-references as something that applies across the whole ns form, but typically these are nested inside just a single clause. I'm guessing :verbose is the same way? I could see issues with ns forms that have multiple :require clauses, one for :reloads and one without. However, I don't think the old code handled this properly anyway, and IMO it's of questionable worth--arguably :reload isn't something you'd leave in your source but something you'd insert while working on something and remove once you got it figured out. Appreciate all the work you've put into this lib; it's great to see it mature.